[typescript] replace headers with same case-insensitive key to match http spec#22393
Merged
macjohnny merged 5 commits intoOpenAPITools:masterfrom Nov 25, 2025
Merged
Conversation
macjohnny
approved these changes
Nov 25, 2025
Member
macjohnny
left a comment
There was a problem hiding this comment.
thanks for this improvement!
lucy66hw
pushed a commit
to lucy66hw/openapi-generator
that referenced
this pull request
Dec 16, 2025
…http spec (OpenAPITools#22393) * replace headers with same caseinsensitive key to match http spec * regenerate samples * regenerate samples * enable test for header case-insensitive replacement * reduce redundant test comments
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…http spec (OpenAPITools#22393) * replace headers with same caseinsensitive key to match http spec * regenerate samples * regenerate samples * enable test for header case-insensitive replacement * reduce redundant test comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
respect http header case-insensitivity
kubernetes-client/javascript#2690
to maximize backward compatibility, this PR preserves header casing.
when a new header is set that is case-insensitively equal to an existing header, the old header key and value will be deleted prior to setting the new one.
setHeaderParam('key','value')should delete a value previously set bysetHeaderParam('kEy','old-value')https://www.rfc-editor.org/rfc/rfc7540#section-8.1.2
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)