Rust-server: implement ValidateComposited traits for complex types and add integer enum support#23045
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Feb 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 30 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/server/petstore/rust-server/output/openapi-v3/examples/client/main.rs">
<violation number="1" location="samples/server/petstore/rust-server/output/openapi-v3/examples/client/main.rs:83">
P2: `QueryExampleGet` is still listed as an accepted CLI operation, but its match arm is commented out, so choosing it will fall through to `panic!("Invalid operation provided")`. Remove it from the accepted list or re-enable the handler to avoid runtime panics for a valid option.</violation>
</file>
<file name="samples/server/petstore/rust-server/output/petstore-with-fake-endpoints-models-for-testing/examples/client/main.rs">
<violation number="1" location="samples/server/petstore/rust-server/output/petstore-with-fake-endpoints-models-for-testing/examples/client/main.rs:296">
P2: CLI accepts operations (e.g., LoginUser/DeleteUser) that no longer have match arms, so valid inputs now hit the default panic at runtime.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
samples/server/petstore/rust-server/output/openapi-v3/examples/client/main.rs
Outdated
Show resolved
Hide resolved
...e/rust-server/output/petstore-with-fake-endpoints-models-for-testing/examples/client/main.rs
Show resolved
Hide resolved
…es and add integer enum support
davidricodias
pushed a commit
to davidricodias/openapi-generator
that referenced
this pull request
Mar 11, 2026
…es and add integer enum support (OpenAPITools#23045)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client example generator in processParam used an empty string fallback when no example was specified in the OpenAPI spec. For boolean and numeric primitive types this produced invalid Rust, either empty arguments or bare commas, this caused compilation failures in the generated client examples.
These defaults appear only in generated client example code (examples/client/main.rs) and are commented. Parameters of other types without examples continue to disable the operation via the existing x-no-client-example mechanism.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds serde_valid composite validation traits to rust-server models, improves client example generation to avoid invalid Rust, and adds integer enum support. Client examples now skip operations when required query params lack examples, and query param examples are only used when provided in the spec.
New Features
Bug Fixes
Written for commit 9cac9c8. Summary will update on new commits.