Add tests for MySQL row-level locking clauses#342
Merged
JanJakes merged 1 commit intoWordPress:trunkfrom Apr 3, 2026
Merged
Conversation
JanJakes
reviewed
Apr 3, 2026
Member
JanJakes
left a comment
JanJakes
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I only have some small notes, and it needs a rebase to resolve conflict.
Additionally, I will update the title and description to accurately reflect that this adds test coverage.
Thanks!
tests/WP_SQLite_Driver_Tests.php
Outdated
| } | ||
|
|
||
| public function testLockingClauses() { | ||
| $this->engine->query( "INSERT INTO _options (option_name, option_value) VALUES ('test_lock', '1')" ); |
Member
There was a problem hiding this comment.
As in other tests, we should use assertQuery to assert that no errors were triggered. It's also better to create a new table for the test (I consider these pre-created tables to be legacy, and would like to get rid of them).
JanJakes
changed the title
JanJakes
force-pushed
the
feature/pr-1-locking-clauses
branch
from
e434eb9 to
aeb07b4
Compare
Member
|
I went ahead and rebased + updated the tests myself. Also added tests for other mentioned statements like |
Merged
JanJakes
added a commit
that referenced
this pull request
Apr 3, 2026
## Release `2.2.22` Version bump and changelog update for release `2.2.22`. **Changelog draft:** * Support INSERT without INTO keyword ([#354](#354)) * Add tests for MySQL row-level locking clauses ([#342](#342)) * Improve automated deploy setup. **Full changelog:** v2.2.21...release/v2.2.22 ## Next steps 1. **Review** the changes in this pull request. 2. **Push** any additional edits to this branch (`release/v2.2.22`). 3. **Merge** this pull request to complete the release. Merging will automatically build the plugin ZIP, create a [GitHub release](https://github.com/WordPress/sqlite-database-integration/releases), and deploy to [WordPress.org](https://wordpress.org/plugins/sqlite-database-integration/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for MySQL row-level locking clauses (e.g.,
FOR UPDATE,LOCK IN SHARE MODE,SKIP LOCKED,NOWAIT) by ensuring they are safely ignored during translation to SQLite.