Conversation
Co-authored-by: Jáchym Toušek <enumag@gmail.com>
|
Nice! I was planning to take care of this but you were faster. Looks good to me. :-) |
|
@tlvanknippenberg Thanks! You currently do not have your GPG key uploaded into your account, so your commits show up as |
|
We could also make it compatible with both, I guess? Check whether the new function exists and fallback to the old one? |
Good point. I have added keys to my account for future commits. Thanks! |
|
Regarding the backwards compatibility, would something like this be acceptable? (line 38) |
|
@tlvanknippenberg Yes, exactly, but we'll need |
|
Thanks! |
* master: Fix file cache keeping the GC watcher referenced (#14) Migrate PHPUnit configuration Update license Increase timeout in AtomicCacheTest for macOS Upgrade psalm to 4.x Fix static analysis errors Switch to GitHub Actions Support amphp/file v2 (#12) # Conflicts: # .gitignore # composer.json # lib/ArrayCache.php # lib/Cache.php # lib/FileCache.php # lib/NullCache.php # lib/SerializedCache.php # phpunit.xml.dist
I have taken the liberty of updating FileCache.php to be inline with the v2 amphp/file methods.
(This is the first time in a long while since I've contributed anything to OSS. Please let me know if I have missed anything.)