Skip to content

[C++] Support iterable types for RowEncoder#1215

Merged
chaokunyang merged 1 commit intoapache:mainfrom
PragmaTwice:encoder-wrapper-array
Dec 7, 2023
Merged

[C++] Support iterable types for RowEncoder#1215
chaokunyang merged 1 commit intoapache:mainfrom
PragmaTwice:encoder-wrapper-array

Conversation

@PragmaTwice
Copy link
Copy Markdown
Member

@PragmaTwice PragmaTwice commented Dec 7, 2023

What do these changes do?

In this PR, we support iterable types for RowEncoder.

Refer to src/fury/encoder/row_encoder_test.cc for how to use.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

Copy link
Copy Markdown
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit fa7c7a1 into apache:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants