Issue 21316 windows node11#2699

zerdos · 2018-10-31T21:29:05Z

Related issue: #2667

…at. [skip ci]

…s into issue_21316_windows-node11

chrisbreiding

aldarund · 2018-11-01T15:37:03Z

@zerdos That PR dont fix the issue in the ticket.
As you can see on line 68 of util.js https://github.com/cypress-io/cypress/pull/2699/files#diff-ff7fed4466b74a64c92a94073a299a3dR68 it converts boolean to 0 or 1 string. And then it dont work because of this. If pass false instead of 0 it will work. But it dont work with 0.

…s into issue_21316_windows-node11

This reverts commit 9ecd31b.

zerdos · 2018-11-02T07:11:42Z

@zerdos That PR dont fix the issue in the ticket.
As you can see on line 68 of util.js https://github.com/cypress-io/cypress/pull/2699/files#diff-ff7fed4466b74a64c92a94073a299a3dR68 it converts boolean to 0 or 1 string. And then it dont work because of this. If pass false instead of 0 it will work. But it dont work with 0.

I made a modification and now it should work!

# Conflicts: # package.json

mikecousins · 2018-11-12T18:57:49Z

This would be pretty great to get merged. It's killing us right now.

…-node11-local

…s-node11-local

kuceb · 2018-11-28T20:44:35Z

@aldarund the problem is windowsHide is not a prop of options.env, its a prop of options
https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options

This reverts commit 54ce93b.

* Revert "Issue 21316 windows node11 (#2699) (fixes #2667)" This reverts commit 54ce93b. * add windowsHide prop * fix test name

brian-mann and others added 30 commits October 10, 2017 06:04

Merge branch 'develop'

1581e54

Merge branch 'develop'

87d4f44

Merge branch 'develop'

d29909b

release 1.0.3 [skip ci]

2461681

Merge branch 'develop'

a81d185

Merge branch 'develop'

242c55b

Merge branch 'develop'

5726ef5

Merge branch 'develop'

6e85c3c

Merge branch 'develop'

ce148c5

Merge branch 'develop'

f7729a9

Merge branch 'develop'

e91490f

Merge branch 'develop'

7208cf0

Merge branch 'develop'

4d85570

Merge branch 'develop'

3f36c56

Merge branch 'develop'

4ff28a9

Merge branch 'develop'

af27b63

release 2.0.0 [skip ci]

d83f9e8

Merge branch 'develop'

59f026c

Merge branch 'develop'

81f068e

Merge branch 'develop'

d4a4700

Merge branch 'develop'

cf22c2b

Merge branch 'develop'

6ef26a5

Merge branch 'develop'

c972e7a

Merge branch 'develop'

4476e6c

Add a comment to Issue Template directing questions to be asked in ch…

2e68ab8

…at. [skip ci]

Merge branch 'develop'

ea0c477

Merge branch 'develop'

d656e21

Merge branch 'develop'

af96dff

Merge branch 'develop'

6c85a02

release 3.1.0 [skip ci]

d48d842

Zoltan added 2 commits October 31, 2018 23:30

add getNode11WindowsFix to the utils

8bf7b37

Merge branch 'issue_21316_windows-node11' of github.com:zerdos/cypres…

f6b6334

…s into issue_21316_windows-node11

chrisbreiding requested changes Nov 1, 2018

View reviewed changes

Comment thread cli/lib/util.js Outdated

Zoltan added 8 commits November 1, 2018 16:18

formatting

9ecd31b

do not convert to the windowsHide to string

171e22f

add unit tests

fd150f2

add unit tests

680ee5c

Merge branch 'develop' into issue_21316_windows-node11

649fb58

add unit tests

63f0d4f

Merge branch 'issue_21316_windows-node11' of github.com:zerdos/cypres…

63e2677

…s into issue_21316_windows-node11

Revert "formatting"

9392767

This reverts commit 9ecd31b.

Zoltan Erdos and others added 5 commits November 2, 2018 07:13

Merge branch 'develop' into issue_21316_windows-node11

bfbdd54

don't ask to commit package.json version

5544fa8

release 3.1.1 [skip ci]

f404395

Merge branch 'develop'

ed1378b

# Conflicts: # package.json

Merge branch 'develop' into issue_21316_windows-node11

bf8d471

chrisbreiding added 5 commits November 13, 2018 10:19

Merge remote-tracking branch 'origin/master' into issue_21316_windows…

54abec5

…-node11-local

move isPlatform into cli/util

58e1197

fix version comparison

e9e8e37

revert accidental merge from master

fec755c

Merge remote-tracking branch 'origin/develop' into issue_21316_window…

3c0ff0c

…s-node11-local

chrisbreiding approved these changes Nov 13, 2018

View reviewed changes

chrisbreiding merged commit 54ce93b into cypress-io:develop Nov 13, 2018

kuceb added a commit that referenced this pull request Nov 28, 2018

Revert "Issue 21316 windows node11 (#2699) (fixes #2667)"

d241651

This reverts commit 54ce93b.

kuceb mentioned this pull request Nov 28, 2018

fix windowsHide prop #2853

Merged

brian-mann pushed a commit that referenced this pull request Dec 3, 2018

fix windowsHide prop (#2853)

d57ca55

* Revert "Issue 21316 windows node11 (#2699) (fixes #2667)" This reverts commit 54ce93b. * add windowsHide prop * fix test name

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 21316 windows node11#2699

Issue 21316 windows node11#2699
chrisbreiding merged 54 commits intocypress-io:developfrom
zerdos:issue_21316_windows-node11

zerdos commented Oct 31, 2018 •

edited by jennifer-shehane

Loading

Uh oh!

chrisbreiding left a comment •

edited

Loading

Uh oh!

Uh oh!

aldarund commented Nov 1, 2018 •

edited

Loading

Uh oh!

zerdos commented Nov 2, 2018

Uh oh!

mikecousins commented Nov 12, 2018

Uh oh!

kuceb commented Nov 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

zerdos commented Oct 31, 2018 • edited by jennifer-shehane Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisbreiding left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aldarund commented Nov 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zerdos commented Nov 2, 2018

Uh oh!

mikecousins commented Nov 12, 2018

Uh oh!

kuceb commented Nov 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zerdos commented Oct 31, 2018 •

edited by jennifer-shehane

Loading

chrisbreiding left a comment •

edited

Loading

aldarund commented Nov 1, 2018 •

edited

Loading