bundle v8 that is compatible with bundled node

[juliangruber]

This is process.versions in electron 1.2.0:

{
  "http_parser": "2.7.0",
  "node": "6.1.0",
  "v8": "5.1.281.47",
  "uv": "1.9.0",
  "zlib": "1.2.8",
  "ares": "1.10.1-DEV",
  "modules": "48",
  "openssl": "1.0.2h",
  "electron": "1.2.0",
  "atom-shell": "1.2.0",
  "chrome": "51.0.2704.63"
}

v8 5.1 is not abi compatible with 5.0, which node 6 ships with. So, .modules=48 is incorrect. The way to fix this (I guess) would be to bundle a chrome version that comes with v8 that is compatible with the bundled node version.

See nodejs/nan#578 for answers from node, nan and v8 maintainers.

[zcbenz]

We usually use the same version of NODE_MODULE_VERSION with Node, so NAN can work with Electron without modifications. But there hasn't been a Node release with V8 5.1, and NAN has not been prepared for V8 5.1, it is then not safe for us to change NODE_MODULE_VERSION on our side.

I think the only thing we can do is to wait for Node to release a new version that uses V8 5.1.

[juliangruber]

What about reverting the v8 upgrade then? The problem with the current situation that I and others like @0x00A are facing is that some native modules that do work with node don't work with electron. And I agree with you that it doesn't make much sense to just go ahead and make it abi compatible with node still being behind.

It's not a big deal for me personally to just use electron 1.1.3, but from that point of view you could consider 1.2.0 to be "broken".

[anaisbetts]

@juliangruber Did you rebuild them?

[juliangruber]

@paulatbipsync yes, same results as with the prebuilt binaries

[anaisbetts]

That's surprising, are you sure that your package isn't doing some kind of node-pre-gyp stuff where it's no-op'ing the build?

[juliangruber]

To me that's actually not surprising because v8 5.1 isn't abi compatible with v8 5.0, see nodejs/nan#578 (comment)

[juliangruber]

(And yes, I manually rebuilt and changed stuff around to verify it's not a problem with prebuilts)

[anaisbetts]

Sure, but ABI doesn't matter if you're building from source

[mgol]

V8 5.1 is interesting in that it has only ABI breakages from 5.0 and it seems the Node team plans to apply an API compatibililty layer and merge V8 5.1 to Node 6.

What's the Electron plan to deal with this compatibility layer? NAN will most likely assume the layer is present as Node.js 6 will have it.

[anaisbetts]

I feel as if some people on this thread are misusing ABI vs API breaking? Does everyone understand what an ABI-but-not-API breaking change is?

Like, this change breaks ABI but not API:

// In v1.0.0
struct Foo {
   int bar;
   char baz[32];
};

// In v1.0.1
struct Foo {
   char baz[32];
   int bar;
};

// In v1.0.0 bar is located at +0 from the beginning of the struct, in v1.0.1 this is at +0x20
// Compiling this code from source works in both v1.0.0 and v1.0.1, it is not an API break
// but it _is_ an ABI break.
myFoo->bar = 5;

[kkoopa]

Being a header-only library, NAN itself does not care about the ABI. As far as I know, there have been no significant API breakage in V8 5.1 either. Moreover, if NAN did not work, it would almost surely refuse to compile. Thus, NAN is almost surely compatible with V8 5.1. However, none of this applies when using prebuilt binaries of incompatible ABIs.

I am fairly certain that the problem here is ABI related and that the alleged rebuild does not properly build against the V8 version included in Electron, which for all I know could still be different from what is picked up by node-gyp operating on the bundled Node, which does not seem to use its bundled V8 under Electron. That the observed problem could not be reproduced on Windows, which does not support prebuild, points towards this.

There is no apparent reason why Nan::Null, which does nothing but forward to v8::Null would evaluate to true. It simply makes no sense, unless there is an ABI incompatibility. One possibility is that the attempts to rebuild the Node addon were built against the V8 version bundled in the bundled Node, which is not what Electron uses. It could also have been built against some other V8 version on the local file system. Who knows.