Support field attributes on vertex and constant structures#1373
Merged
kvark merged 2 commits intogfx-rs:pre-llfrom Sep 27, 2017
Merged
Support field attributes on vertex and constant structures#1373kvark merged 2 commits intogfx-rs:pre-llfrom
kvark merged 2 commits intogfx-rs:pre-llfrom
Conversation
Member
|
@mzmonsour is this ready to ship? |
mzmonsour
force-pushed
the
macro-field-attrs
branch
from
57d9d61 to
c29b9f7
Compare
Contributor
Author
|
The PR should be ready to merge. I tried adjusting the appveyor config, although I may have messed something up in the process of targeting pre-ll, since appveyor is complaining about the PR. Let me know if there's something else I should fix. |
Member
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 27, 2017
1373: Support field attributes on vertex and constant structures r=kvark a=mzmonsour Adds support for attributes on struct fields, such as doc comments. This doesn't work on stable because of a macro parser bug. Wait until rust-lang/rust#42913 is in a stable release (1.20 probably) before merging this.
Contributor
Build failed |
alexheretic
pushed a commit
to alexheretic/gfx
that referenced
this pull request
Oct 2, 2017
* Apply field attributes for gfx_defines! structures * Appveyor should target Rust 1.20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for attributes on struct fields, such as doc comments. This doesn't work on stable because of a macro parser bug. Wait until rust-lang/rust#42913 is in a stable release (1.20 probably) before merging this.