Introduce concept of active view#1096
Merged
Manishearth merged 1 commit intoimmersive-web:masterfrom Jul 8, 2020
Merged
Conversation
toji
approved these changes
Jul 8, 2020
Member
toji
left a comment
toji
left a comment
There was a problem hiding this comment.
LGTM with one non-blocking question
|
|
||
| A [=view=] has an associated <dfn for="view">eye</dfn> which is an {{XREye}} describing which eye this view is expected to be shown to. If the view does not have an intrinsically associated eye (the display is monoscopic, for example) this value MUST be set to {{XREye/"none"}}. | ||
|
|
||
| A [=view=] has an <dfn for="view">active</dfn> flag that may change through the lifecycle of an {{XRSession}}. [=Primary views=] SHOULD always have the [=view/active=] flag set to <code>true</code>. |
Member
There was a problem hiding this comment.
Any reason why we don't say the primary views MUST always be active?
Contributor
Author
There was a problem hiding this comment.
Because that's a new constraint, the thing defining a primary view is that without it the system cannot perform. It's not impossible for devices to have primary views that are variable, it's just weird.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explicitly draws a distinction between active and inactive views, so that the list of views and viewports becomes immutable.
Fixes #1094 (comment)
Needed for immersive-web/layers#180 (comment)
cc @asajeffrey @cabanier
Preview | Diff