Ensure an immersive device is selected in makeXRCompatible()#809
Merged
toji merged 2 commits intoimmersive-web:masterfrom Aug 16, 2019
Merged
Ensure an immersive device is selected in makeXRCompatible()#809toji merged 2 commits intoimmersive-web:masterfrom
toji merged 2 commits intoimmersive-web:masterfrom
Conversation
toji
reviewed
Aug 16, 2019
index.bs
Outdated
| 1. If |context|'s [=XR compatible=] boolean is <code>true</code>, [=/resolve=] |promise| and abort these steps. | ||
| 1. [=ensures an immersive XR device is selected|Ensure an immersive XR device is selected=]. | ||
| 1. If the [=XR/immersive XR device=] is <code>null</code>: | ||
| 1. Set |context|'s [=XR compatible=] boolean to <code>true</code>. |
Member
There was a problem hiding this comment.
This should be false, shouldn't it? (It would still allow for inline sessions, which don't check for context compatibility.)
Contributor
Author
There was a problem hiding this comment.
copy paste bug 😄
toji
requested changes
Aug 16, 2019
Member
toji
left a comment
toji
left a comment
There was a problem hiding this comment.
The create-with-compatible-xr-device algorithm also needs to ensure a device is selected prior to running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #778
cc @asajeffrey
r? @toji