Merged
Conversation
Checking to see if this causes more fulsome stack trace information to appear is the Sentry UI.
Maybe this will do some more.
scottbarnes
force-pushed
the
update-sentry-sdk
branch
from
504c733 to
34260f5
Compare
Just do this while using testing.openlibrary.org prior to update of olsystem.
This reverts commit 4c20717.
cdrini
reviewed
Jan 20, 2026
| traces_sample_rate=self.config.get('traces_sample_rate', 0.0), | ||
| profiles_sample_rate=self.config.get('profiles_sample_rate', 0.0), | ||
| release=get_software_version(), | ||
| enable_logs=self.config.get('enable_logs', True), |
Collaborator
There was a problem hiding this comment.
Note if we default this to true it will run for covers, cron jobs, etc, which we haven't tested. But I'm happy to merge, so long as we're aware this might result in unexpected strain on sentry which we might have to update on-the-fly and flip to false for somethings.
Collaborator
Author
There was a problem hiding this comment.
This was just for testing because https://github.com/internetarchive/olsystem/pull/302 wouldn't take effect on testing.
It's a bit buried in the commits, but this is meant to be temporary.
The other problem is that this change seemed to stop logging of everything, including WARNING and ERROR. So I will need to look at it more (I reverted the change in the next commit to verify it was the problem). :(
bhardwajparth51
added a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Feb 17, 2026
…ry-sdk Update Sentry SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Sentry SDK to get support for structured logging: https://blog.sentry.io/logs-generally-available/
Closes #
Technical
Testing
Screenshot
Stakeholders