feat: Add Internet Archive Save Page Now integration#11243
Merged
mekarpeles merged 12 commits intointernetarchive:masterfrom Nov 18, 2025
Merged
feat: Add Internet Archive Save Page Now integration#11243mekarpeles merged 12 commits intointernetarchive:masterfrom
mekarpeles merged 12 commits intointernetarchive:masterfrom
Conversation
- add archive.py module for Save Page Now API integration in OL
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
mekarpeles
reviewed
Sep 12, 2025
openlibrary/core/archive.py
Outdated
| if not access_key or not secret_key: | ||
| if config: | ||
| # Use the same S3 credentials as other IA services | ||
| s3_config = config.get('ia_ol_xauth_s3') |
Member
There was a problem hiding this comment.
We probably want to use a different key pair for this purpose
Member
|
Looks good to me overall
squash on merge |
Contributor
Author
|
Sounds good.
|
…pytest integration test
Contributor
Author
|
moved the changes, for testing
For testing run |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ishank-dev
commented
Sep 23, 2025
Contributor
Author
|
@mekarpeles for these new changes to work with internetarchive python library I need inputs and help in verifying if it will pick credentials in beta or prod cloud environment as per the docs, it reads ~/.config/ia.ini (or ~/.ia) for the running user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11090
Add archive.py module for Save Page Now API integration in OL
Technical
is_already_archived(url)- Checks Wayback Machine availability APIarchive_url(url, ...)- Submits URLs to Save Page Now APITesting
Tests use sample URLs from this collab: https://colab.research.google.com/drive/1y7c4n34N6oahlMjImDfG1QzembHWUJW4#scrollTo=g4YZshpc_ICP
Screenshot
Stakeholders
@mekarpeles