fix: improve UX and clarity for Bulk Search#11358
fix: improve UX and clarity for Bulk Search#11358cdrini merged 14 commits intointernetarchive:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the user experience of the Bulk Search feature by adding visual feedback and clearer instructions. The changes focus on guiding users through a three-step process with better visual indicators and explicit instructions.
- Implements auto-scrolling to active steps and adds visual highlighting with blue borders
- Distinguishes the primary book result (first card) from secondary results using opacity and border styling
- Adds instructional text to clarify the spreadsheet copy/paste workflow
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| openlibrary/components/BulkSearch/components/BulkSearchControls.vue | Adds auto-scroll behavior, activeStep tracking, visual step highlighting, and instructional text for the bulk search workflow |
| openlibrary/components/BulkSearch/components/BookCard.vue | Implements primary/secondary card styling with opacity differences and border highlighting |
| openlibrary/components/BulkSearch/components/TableRow.vue | Passes isPrimary prop to BookCard to identify the first result |
| openlibrary/components/BulkSearch/components/MatchRow.vue | Passes isPrimary prop to BookCard to identify the first result |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…z/openlibrary into improvements-in-bulk-search-ui
|
PTAL @cdrini, thanks. |
cdrini
left a comment
There was a problem hiding this comment.
Nice great work @akramcodez ! A few small tweaks for styling 👍
openlibrary/components/BulkSearch/components/BulkSearchControls.vue
Outdated
Show resolved
Hide resolved
openlibrary/components/BulkSearch/components/BulkSearchControls.vue
Outdated
Show resolved
Hide resolved
openlibrary/components/BulkSearch/components/BulkSearchControls.vue
Outdated
Show resolved
Hide resolved
openlibrary/components/BulkSearch/components/BulkSearchControls.vue
Outdated
Show resolved
Hide resolved
…rs, update styling
for more information, see https://pre-commit.ci
|
@cdrini thanks for the suggestions, all implemented. |
|
@cdrini if there's any problem, please let me know. |
|
Hi @akramcodez , please make sure to resolve all the cr comments (see https://github.com/internetarchive/openlibrary/blob/master/CONTRIBUTING.md#submitting-pull-requests ). That's what signals to me the PR is ready for another look! Also note it seems like we lost the scrollIntoView logic with the latest changes. That will need to be restored. |
|
Hi @cdrini, sorry about that I had pushed the changes but forgot to resolve the review comments. I've now resolved them and also restored the scrollIntoView logic. |
cdrini
left a comment
There was a problem hiding this comment.
Looks great! Thank you @akramcodez
Closes #11347
Changes
Screen recording
video.mov