11377/fix/blank cover on edit book positioning#11378
Merged
cdrini merged 2 commits intointernetarchive:masterfrom Jan 8, 2026
Merged
11377/fix/blank cover on edit book positioning#11378cdrini merged 2 commits intointernetarchive:masterfrom
cdrini merged 2 commits intointernetarchive:masterfrom
Conversation
github-project-automation
bot
moved this to Waiting Review/Merge from Staff
in Ray's Project
RayBB
requested changes
Nov 5, 2025
Collaborator
RayBB
left a comment
RayBB
left a comment
There was a problem hiding this comment.
Tested and it works! Just one bit of feedback
Comment on lines
27
to
28
| display: none; | ||
|
|
Collaborator
There was a problem hiding this comment.
I think we can add it here instead and then we don't need to add a new css class to the html.
What do you think?
Contributor
Author
There was a problem hiding this comment.
That is what I initially thought as well, but the SRPCoverBlank class is also used on the edition page of the book. Defining the left shift in SRPCoverBlank will change the blank cover to look like this on the edition page:
Contributor
Author
github-actions
bot
added
the
Needs: Response
RayBB
added
Needs: Staff / Internal
Collaborator
|
Bumping @cdrini for merging |
Collaborator
|
Nice thank you! This whole page I reckon needs a bit of rejiggering into more modern CSS to allow us to better position things, but this seems like a great fix for now, thank you @emggeorge ! |
github-project-automation
bot
moved this from Waiting Review/Merge from Staff
to Done
in Ray's Project
mystic-06
pushed a commit
to mystic-06/openlibrary
that referenced
this pull request
Jan 11, 2026
* add class to make changes specificall on blank cover in edition edit * shift cover so that it is centered in its box
lokesh
pushed a commit
to lokesh/openlibrary
that referenced
this pull request
Feb 4, 2026
* add class to make changes specificall on blank cover in edition edit * shift cover so that it is centered in its box
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11377
PR fixes blank cover box positioning when editing an edition.
Technical
This PR creates a new class named editEditionCover that shifts the SRPCoverBlank box left by 22px. This is the distance it needs to be moved to center it based on the predefined width of the cover and the size of the container for the cover.
Testing
Add a book that has no cover and select edit on the edition page.
Screenshot
Blank cover in the correct position
Blank cover unaffected by proposed changes on the edition page
Stakeholders