Skip to content

Implement user agent monitoring for Graphite#11453

Merged
cdrini merged 3 commits intomasterfrom
add-partner-ua-monitoring
Nov 28, 2025
Merged

Implement user agent monitoring for Graphite#11453
cdrini merged 3 commits intomasterfrom
add-partner-ua-monitoring

Conversation

@mekarpeles
Copy link
Copy Markdown
Member

Added user agent monitoring functionality to track and normalize user agent counts for Graphite metrics.

Adds basic monitoring to ensure DLAI user agent is succeeding.

Related to DLAI to see how often requests are succeeding

Technical

Testing

Screenshot

Stakeholders

Added user agent monitoring functionality to track and normalize user agent counts for Graphite metrics.
Copilot AI review requested due to automatic review settings November 11, 2025 22:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds monitoring functionality to track partner user agent requests for Graphite metrics. The implementation extracts user agent counts from nginx logs and submits them to Graphite for visualization and alerting.

  • Adds a new scheduled monitoring function monitor_partner_useragents() that runs every 60 seconds
  • Implements helper functions for normalizing user agent strings and extracting counts from log data
  • Tracks known partner user agents with an "other" category for unrecognized agents

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, one small change for consistency with the other dashboards. Otherwise has been running smoothly on prod for a while now. There is some weird banding going on in the graphs... but not sure why that is.

image

@cdrini cdrini added the Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. label Nov 28, 2025
@cdrini cdrini merged commit 7951d38 into master Nov 28, 2025
8 checks passed
@cdrini cdrini deleted the add-partner-ua-monitoring branch November 28, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants