Replace custom cached_property with functools.cached_property#11480
Merged
mekarpeles merged 1 commit intomasterfrom Dec 1, 2025
Merged
Replace custom cached_property with functools.cached_property#11480mekarpeles merged 1 commit intomasterfrom
mekarpeles merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the codebase by replacing a custom cached_property implementation with Python's standard library functools.cached_property (available since Python 3.8).
- Removes the custom
cached_propertydecorator function (22 lines of code) - Updates the single usage in
MemcacheCache.memcacheto usefunctools.cached_property - Removes
cached_propertyfrom the module's__all__exports
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #11479 . This is now built-in to python and can be replaced with functools.cached_property . It was only used in one spot.
Technical
Added in python 3.8, it has the same semantics as our version, namely that it is store for the life time of the instance:
Testing
Screenshot
Stakeholders