Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR completes the migration from the requests library to httpx by updating the exception handling in the save_page_now function. This is a followup to PR #11090.
Key Changes:
- Updated exception handling from
requests.RequestExceptiontohttpx.RequestExceptionto align with the httpx library
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RayBB
approved these changes
Nov 18, 2025
Collaborator
RayBB
left a comment
RayBB
left a comment
There was a problem hiding this comment.
@mekarpeles thanks I was hitting this too. Can confirm this is the change we need.
jimchamp
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #11090 ; fixes
requestsreference, replaced withhttpxThis pull request makes a small update to the exception handling in the
save_page_nowfunction inopenlibrary/core/ia.py. The change switches the caught exception fromrequests.RequestExceptiontohttpx.RequestException, likely reflecting a transition from therequestslibrary tohttpxfor HTTP requests.