Tweak tagger/nginx rate limit logic#11605
Merged
jimchamp merged 4 commits intointernetarchive:masterfrom Dec 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the nginx rate limiting and request filtering logic to better detect and handle suspicious traffic patterns, with coordinated changes to the tagger system in the related olsystem repository.
Key changes:
- Enhanced referer detection to catch clients sending literal
"-"as referer value - Expanded rate limiting to include suspicious IPs in addition to non-identifying crawlers
- Added dedicated cover image rate limits for non-identifying crawlers to prevent abuse while allowing legitimate batch cover loading
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
docker/web_nginx.conf |
Enhanced referer detection to recognize "-" as empty referer; expanded paths requiring referer to include subjects, authors, and search pages; removed direct $is_sus_referer enforcement (delegated to tagger.js) |
docker/nginx.conf |
Updated file extension from .map to .conf for consistency; added is_sus_ip.conf include; extended crawler rate limit logic to incorporate suspicious IPs; increased global crawler rate limit from 15r/s to 17r/s; added dedicated 150r/s cover rate limit for non-identifying crawlers |
docker/covers_nginx.conf |
Applied new global_crawler_cover_limit zone to cover endpoints |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jimchamp
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also https://github.com/internetarchive/olsystem/pull/292
Technical
Testing
Screenshot
Stakeholders