Updates script to write all preferences to store

[jimchamp]

Advances #11009

Adds --legacy flag to the preference migration script. When --legacy is true, all remaining preferences in the thing table will be written to the store.

Technical

Testing

Screenshot

Stakeholders

[Copilot]

Pull request overview

This PR adds a --legacy flag to the preference migration script that allows writing all remaining preferences from the thing table to the store table, rather than just a subset based on specific criteria.

• Introduces new _fetch_legacy_preference_keys() function to query all preferences in thing table not yet in store
• Adds --legacy command-line flag to switch between the two migration modes
• Updates documentation to reflect the new functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
scripts/migrations/write_prefs_to_store.py	Adds new _fetch_legacy_preference_keys() function and --legacy argument to enable migration of all preferences
scripts/migrations/README.md	Updates description to document the --legacy flag functionality

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new function lacks transaction handling that exists in the original _fetch_preference_keys() function. The original function creates a transaction with t = oldb.transaction() and performs a rollback in both the error case and the success case. This transaction pattern should be replicated here for consistency and to ensure proper database resource management.

Suggested change

	keys = []
	try:
	legacy_preference_entries = oldb.query(legacy_key_query)
	keys = [entry.get('key', '') for entry in list(legacy_preference_entries)]
	except DatabaseError as e:
	print(f"An error occurred while fetching preference keys: {e}")
	keys = []
	t = None
	try:
	t = oldb.transaction()
	legacy_preference_entries = oldb.query(legacy_key_query)
	keys = [entry.get('key', '') for entry in list(legacy_preference_entries)]
	except DatabaseError as e:
	if t is not None:
	t.rollback()
	print(f"An error occurred while fetching preference keys: {e}")
	else:
	if t is not None:
	t.rollback()

[jimchamp]

The transaction in the other function was added to support the use of a temporary table. Rolling back that transaction cleans up the temporary table.

Also, I'm not exactly sure what benefit could be had by rolling back the single SELECT query that is executed in this function......