Conversation
cdrini
added
the
Patch Deployed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the nginx configuration to externalize the IP whitelist configuration by moving the hardcoded is_blessed_ip geo block to an external configuration file. This aligns with the pattern already used for other similar configurations like is_blessed_ua and is_sus_ip.
Key Changes:
- Removed hardcoded geo block defining blessed IPs (255.0.0.0 and 207.241.224.0/20) from nginx.conf
- Added include directive for external
/olsystem/etc/nginx/is_blessed_ip.conffile
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jimchamp
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #11611
Technical
Testing
Screenshot
Stakeholders