test: Significantly refactor and expand WaitingLoan unit tests#11733
Merged
mekarpeles merged 1 commit intomasterfrom Jan 26, 2026
Merged
test: Significantly refactor and expand WaitingLoan unit tests#11733mekarpeles merged 1 commit intomasterfrom
mekarpeles merged 1 commit intomasterfrom
Conversation
Member
|
This is all movement in the right direction -- I think we really want to get the waiting loan info from the /serivces/loans official API and effectively phase out / delete openlibrary's waitingloan logic. This is related to our discussions over slack. |
Collaborator
Author
|
Related issue: #11232 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of 3 xfailed tests there is only 1 left now.
Technical
Testing
Screenshot
Stakeholders