cleanup 'old_plugins' code to have explicit imports#11762
Merged
Conversation
cdrini
reviewed
Feb 17, 2026
Collaborator
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Some initial thoughts but needs some more testing
cdrini
approved these changes
Feb 25, 2026
Collaborator
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Lgtm! Tested some basic flows for admin page and stuff and it seems like the plugins are being loaded correctly. Not I did notice that on testing the recaptcha isn't loading on login/signup? But I think unrelated to this PR, but that's a blocking issue I need to investigate.
RayBB
added a commit
that referenced
this pull request
Feb 26, 2026
* cleanup 'old_plugins' code to have explicit imports * remove unneeded imports * move calls into openlibrary_setup and reorder
bhardwajparth51
pushed a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Mar 3, 2026
…11762) * cleanup 'old_plugins' code to have explicit imports * remove unneeded imports * move calls into openlibrary_setup and reorder
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11758
Technical
Long story short, the code looked very complicated and seemed to be doing some magical stuff.
But really only one folder was making use of it and the rest can be done by calling setup to ensure we import and register the urls for web.py
This is a handy cleanup as we move towards fastapi
Testing
It's on testing.
In local all the associated pages seemed to still work fine. Also very clear when I remove a setup import it completely knocks off pages right away.
Screenshot
Stakeholders