Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the book edit POST handler to remove redundant logic used to decide which flash message to display after saving an edited book (follow-up to #10881).
Changes:
- Removes the unused
addboolean calculation in the book edit POST handler. - Collapses an
if/elsewhere both branches executed the sameadd_flash_message(...)call into a single statement.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bhardwajparth51
added a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Feb 17, 2026
…ssage-code-clean-up DRY book edit flash message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10881
In support of micro edits.
Removes conditional from book editing POST handler that checks if a new book was created. Both branches executed the exact same code...
Also removes boolean variable
add, which was only used by the removed conditional.Technical
Testing
Screenshot
Stakeholders