Remove unused method from SaveBookHelper#11776
Merged
mekarpeles merged 2 commits intomasterfrom Feb 9, 2026
Merged
Conversation
jimchamp
force-pushed
the
rm-unused-method
branch
from
2a21087 to
643a1f5
Compare
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes backend code that supported adding contributors, identifiers, and classifications to /config/edition via the edit book UI. This functionality was already removed from the frontend in PR #8261, making this backend code unused.
Changes:
- Removed the unused
process_new_fieldsmethod from theSaveBookHelperclass - Removed the call to
process_new_fieldsin thesavemethod - Removed unused imports (
jsonandas_admin)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bhardwajparth51
added a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Feb 17, 2026
* Remove used method --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8261
In support of micro edits.
#8261 totally removes the ability to add new contributor, identifier, and classifications to
/config/editionvia the edit book UI. This branch removes the corresponding backend code.Technical
Testing
Screenshot
Stakeholders