migrate /people/{username}/books/{key}.json to fastapi#11926
Merged
Conversation
RayBB
changed the title
/people/{username}/books/{key}.json to fastapi
cdrini
approved these changes
Feb 25, 2026
Collaborator
There was a problem hiding this comment.
Lgtm! Testing worked well. One blocker with regards to handling invalid cases like invalid username / private reading log.
Note this is a slight breaking change because this endpoint now returns a different error message and returns non-200 status code. Non-200 status codes for error cases is consistent with fastapi's best practices though ; they return eg 422 automatically when the parameters don't match the types.
Comment on lines
+60
to
+61
| page: int = Query(1, ge=1), | ||
| limit: int = Query(100, ge=1, le=1000), |
Collaborator
There was a problem hiding this comment.
Can we use the pagination model to make this api consistent with the others?
bhardwajparth51
pushed a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Probably will have merge conflicts with #11925
Technical
Testing
Screenshot
Stakeholders