Don't copy compose.override.yaml during deploy#11935
Merged
mekarpeles merged 1 commit intointernetarchive:masterfrom Feb 25, 2026
Merged
Don't copy compose.override.yaml during deploy#11935mekarpeles merged 1 commit intointernetarchive:masterfrom
mekarpeles merged 1 commit intointernetarchive:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a safety measure to the deployment script to prevent compose.override.yaml from being deployed to production servers. This is an addendum to PR #11902, which added Solr auto-rebuild functionality triggered by the LOCAL_DEV=true environment variable.
Changes:
- Explicitly removes
compose.override.yamlafter copying compose files to prevent local dev configurations from reaching production servers
Comments suppressed due to low confidence (1)
scripts/deployment/deploy.sh:392
- The wildcard pattern
compose*.yamlon line 389 also matchescompose.infogami-local.yaml, which is another local development-only file. This file mounts local vendor/infogami directories and should not be deployed to production servers. Consider also removing it here withrm -f openlibrary_new/compose.infogami-local.yaml.
rm -f openlibrary_new/compose.override.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addendum to #11902
Technical
Testing
Screenshot
Stakeholders