enable ruff check on fastapi api files in prep for migration#11940
Merged
enable ruff check on fastapi api files in prep for migration#11940
Conversation
RayBB
changed the title
RayBB
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
All this PR does is enable ruff check on a few files. The rest of the changes are automated.
I'm going to be doing some big work on the
api.pyfile and to make the best use of AI it would help a lot to have ruff formatting these files (it's much faster a bit more compact).Since I'll also likely touch quite some tests in reworking api.py and there are currently no open PRs for any tests I'm also adding them.
Technical
To check what files have no open PRs I use
gh pr list --limit 1000 --state open --json number,title,files,url,isDraft,updatedAt,authorand
comm -23 <(find . -type f -name "*.py" -exec dirname {} \; | sed 's|^\./||' | sort -u) <(jq -r '.[] | select(.isDraft == false) | .files[].path | select(endswith(".py"))' pr_cache.json | xargs dirname | sort -u)Then sanity check in the raw json itself from gh.
Testing
Screenshot
Stakeholders