Add shortlist of user-agent rate limit#12115
Merged
mekarpeles merged 2 commits intointernetarchive:masterfrom Mar 17, 2026
Merged
Add shortlist of user-agent rate limit#12115mekarpeles merged 2 commits intointernetarchive:masterfrom
mekarpeles merged 2 commits intointernetarchive:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an additional nginx rate-limiting layer keyed off a shortlist of user agents (intended to be more permissive than the default), and tightens some request classification rules in the nginx frontend configs used by the dockerized deployment.
Changes:
- Add a new
ua_rate_limitlimit zone and apply it to/and API/JSON requests. - Make “sus user agent” matching case-insensitive for specific blocked UAs.
- Treat
mode=allrequests as requiring referrer checks (via$requires_referermapping).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
docker/web_nginx.conf |
Updates UA matching, adds mode=all to the “requires referrer” classifier, and applies the new ua_rate_limit in key locations. |
docker/nginx.conf |
Adds an include expected to define $ua_rate_limit_key and defines the new ua_rate_limit zone. |
cdrini
added a commit
to cdrini/openlibrary
that referenced
this pull request
Mar 21, 2026
Add shortlist of user-agent rate limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves this from prod onto here.
Requires https://github.com/internetarchive/olsystem/pull/317
Technical
Testing
This was roughly tested, but has since been cleaned up and tightened, so there might be adjustments that need to be made.
Screenshot
Stakeholders