Update ia.py to fix the undefined IA base url#8610
Merged
mekarpeles merged 3 commits intointernetarchive:masterfrom Feb 26, 2026
Merged
Update ia.py to fix the undefined IA base url#8610mekarpeles merged 3 commits intointernetarchive:masterfrom
mekarpeles merged 3 commits intointernetarchive:masterfrom
Conversation
krishnapatel17
changed the title
RayBB
added
the
Needs: Review
mekarpeles
added
Needs: Testing
and removed
Needs: Review
Member
|
Some scripts may not call https://github.com/internetarchive/openlibrary/blob/master/openlibrary/core/lending.py |
mekarpeles
reviewed
Feb 26, 2026
bhardwajparth51
pushed a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Mar 3, 2026
* Update ia.py to fix the bug of undefined IA base url; default to archive.org --------- Co-authored-by: Mek <michael.karpeles@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4437
Fixes IA_BASE_URL not being read from openlibrary.yml
Technical
This change modifies the implementation for referencing config to read the IA_BASE_URL by adding a setup method.
Testing
Screenshot
Stakeholders