Add solr fields needed for editions table#9029
Merged
mekarpeles merged 1 commit intointernetarchive:masterfrom Feb 14, 2026
Merged
Add solr fields needed for editions table#9029mekarpeles merged 1 commit intointernetarchive:masterfrom
mekarpeles merged 1 commit intointernetarchive:masterfrom
Conversation
cdrini
force-pushed
the
feature/more-solr-fields
branch
2 times, most recently
from
dd9adc5 to
a7ea225
Compare
Closed
Contributor
|
This seems to be stale enough that it should be closed. |
github-actions
bot
added
the
Needs: Response
cdrini
force-pushed
the
feature/more-solr-fields
branch
from
a7ea225 to
ce2818c
Compare
cdrini
added
Needs: Special Deploy
Collaborator
Author
|
Rebased, we do still want this it just dropped in priority |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds three new fields to the Solr schema to support the editions table feature: work_key, edition_name, and oclc. These fields enable PR #8820 to populate edition tables using Solr data instead of querying the database directly.
Changes:
- Added
work_keyfield to store work references on edition documents - Added
edition_namefield to store edition names in Solr - Added
oclcproperty toEditionSolrBuilderand refactoredWorkSolrBuilder.oclcto use it
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| conf/solr/conf/managed-schema.xml | Added work_key and edition_name field definitions to Solr schema |
| openlibrary/solr/solr_types.py | Updated SolrDocument TypedDict with work_key and edition_name fields |
| openlibrary/solr/updater/edition.py | Added work_key, edition_name, and oclc properties; updated build() to include new fields |
| openlibrary/solr/updater/work.py | Refactored oclc property to use EditionSolrBuilder.oclc instead of raw edition dicts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Created the new fields in solr, so no longer needs a special deploy |
cdrini
removed
the
Needs: Special Deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work to unblock #8820
Technical
Testing
The new fields are being correctly recorded locally
Screenshot
Stakeholders