fix duration_ms

[forrest79]

In this version is duration_ms in seconds but "ms" in variable name is little confusing :-) This fix requires duration_ms in milliseconds.

[cloudbees-pull-request-builder]

plugins » tap-plugin #64 SUCCESS
This pull request looks good

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[kinow]

Hi @forrest79

Sorry for the delay. I'm on a roll fixing bugs, and will cut a few more releases.

I'll massage the code and will fix the conflicts to merge your pull request in the next days.

Thanks!

[harschware]

Thanks for the TAP plugin! I also encountered this issue. I'm hoping a new release will come soon and include the fix.

[rvagg]

This is going to be a pretty awkward change to manage since reporters have standardised around duration_ms as being in seconds (e.g. the Node.js core test runner does this, as do some Node.js ecosystem tap reporters such as Hapi.js). The way I've learnt to read it to solve for the discrepancy is "duration including milliseconds". Perhaps instead of making a breaking change, an alternative could be introduced that is just duration and have that read in either seconds or milliseconds (it really doesn't matter what, since that'd be a new standard), and leave duration_ms for existing reporters that depend on reporting in a certain way.

[gibfahn]

Perhaps the duration option could have an ms or s suffix, e.g. duration: 1.2s or duration: 1000.2ms