Skip to content

Added compressible property to application/yaml#428

Merged
UlisesGascon merged 2 commits intojshttp:masterfrom
GroophyLifefor:bug-i403
Jan 19, 2026
Merged

Added compressible property to application/yaml#428
UlisesGascon merged 2 commits intojshttp:masterfrom
GroophyLifefor:bug-i403

Conversation

@GroophyLifefor
Copy link
Copy Markdown
Member

@GroophyLifefor GroophyLifefor commented Jan 11, 2026

closes to #403
Backlogged in #414

@GroophyLifefor
Copy link
Copy Markdown
Member Author

Hey @UlisesGascon , can you review when available?

Copy link
Copy Markdown
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wil be overwritten the next time we pull the automated changes (or when someoen else runs the build step, even without data updates)

To do changes that are not derived from the upstream datasources you must update the custom-types.js file, which is how we set compressible for text/yaml already, in addition to editing db.json.

So, update custom-types to include

'application/yaml': {
  compressible: true
}

Then run the build, without fetching the data again
npm run build

@GroophyLifefor
Copy link
Copy Markdown
Member Author

Hi @jonchurch, thanks for awesome described PR comment. I understand the problem and fixing in both PR.

@UlisesGascon UlisesGascon self-assigned this Jan 12, 2026
@UlisesGascon UlisesGascon merged commit cbef2e9 into jshttp:master Jan 19, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants