Fix build for powerpc64-unknown-linux-musl#100
Merged
yorickpeterse merged 1 commit intolibffi-rs:masterfrom Apr 4, 2025
Merged
Fix build for powerpc64-unknown-linux-musl#100yorickpeterse merged 1 commit intolibffi-rs:masterfrom
yorickpeterse merged 1 commit intolibffi-rs:masterfrom
Conversation
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Gelbpunkt
added a commit
to Gelbpunkt/rust
that referenced
this pull request
Mar 24, 2025
We intend to fix the outstanding issues on the target and eventually promote it to tier 2. We have the capacity to maintain this target in the future and already perform regular builds of rustc for this target. Currently, all host tools except miri build fine, but I have a patch for libffi-sys to make miri also compile fine for this target that is pending review [1]. While at it, add an option for the musl root for this target. [1]: libffi-rs/libffi-rs#100 Signed-off-by: Jens Reidel <adrian@travitia.xyz>
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 26, 2025
…musl-maintainer, r=compiler-errors Add target maintainer information for powerpc64-unknown-linux-musl We intend to fix the outstanding issues on the target and eventually promote it to tier 2. We have the capacity to maintain this target in the future and already perform regular builds of rustc for this target. Currently, all host tools except miri build fine, but I have a patch for libffi-sys to make miri also compile fine for this target that is [pending review](libffi-rs/libffi-rs#100). While at it, add an option for the musl root for this target. I also added a kernel version requirement, which is rather arbitrarily chosen, but it matches our tier 2 powerpc64le-unknown-linux-musl target so I think it is a good fit.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2025
Rollup merge of rust-lang#138905 - Gelbpunkt:powerpc64-unknown-linux-musl-maintainer, r=compiler-errors Add target maintainer information for powerpc64-unknown-linux-musl We intend to fix the outstanding issues on the target and eventually promote it to tier 2. We have the capacity to maintain this target in the future and already perform regular builds of rustc for this target. Currently, all host tools except miri build fine, but I have a patch for libffi-sys to make miri also compile fine for this target that is [pending review](libffi-rs/libffi-rs#100). While at it, add an option for the musl root for this target. I also added a kernel version requirement, which is rather arbitrarily chosen, but it matches our tier 2 powerpc64le-unknown-linux-musl target so I think it is a good fit.
Contributor
|
Thanks! 🎉 |
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
powerpc64-unknown-linux-muslmatches bothnot(all(target_arch = "powerpc64", target_endian="little"))andall(target_arch = "powerpc64", target_endian = "big", target_env = "musl"), causing a duplicate definition of theelfmodule.powerpc64-unknown-linux-muslshould use ELF v2, so fix the conditional logic to make it use only that.