jenkins: improve x64 node.exe caching for arm64#3842
Merged
StefanStojanovic merged 1 commit intonodejs:mainfrom Jul 31, 2024
Merged
jenkins: improve x64 node.exe caching for arm64#3842StefanStojanovic merged 1 commit intonodejs:mainfrom
StefanStojanovic merged 1 commit intonodejs:mainfrom
Conversation
Fixes: nodejs#3504 Refs: nodejs#3315 Refs: nodejs#3514 Refs: nodejs#3533
StefanStojanovic
added a commit
to JaneaSystems/build
that referenced
this pull request
Aug 1, 2024
This reverts commit 5d0639b. The change being reverted broke test jobs on Windows in the test CI.
StefanStojanovic
added a commit
that referenced
this pull request
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the 2nd attempt to land this (roughly 9 months after the first one). For more details on the reasoning behind this change, please see the description of the 1st attempt. Shortly after it landed (few hours) I noticed the error and reverted the change. For more details on what it was, see the description of the reverting PR.
This time, I made a test job, to make sure there'll be no regressions with the new changes I added on top of the old ones. The run with the changes in this PR can be found here (this change only affects compile jobs, so test failures are not relevant for this).
Fixes: #3504
Refs: #3315
Refs: #3514
Refs: #3533