process: add threadCpuUsage#56467

ShogunPanda · 2025-01-04T06:54:43Z

This PR add the threadCpuUsage method to process.
The method works exactly like cpuUsage but it returns thread specific metrics.
This is already implemented (by me :)) in user-land in https://www.npmjs.com/package/thread-cpu-usage.

The PR is currently a draft as I'm gonna use the CI to see which platform don't support this. I'll add documentation updates once this is solved.

nodejs-github-bot · 2025-01-04T06:54:48Z

Review requested:

@nodejs/startup

nodejs-github-bot · 2025-01-04T06:58:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64336/

santigimeno · 2025-01-04T08:18:23Z

What about moving the platform dependent code to libuv? Maybe taking libuv/libuv#3120 to the finish line would be a good idea.

anonrig

LGTM except couple of questions and concerns

src/node_process_methods.cc

anonrig · 2025-01-05T20:43:24Z

lib/internal/process/per_thread.js

    };
  }

+  const threadCpuValues = new Float64Array(2);


I recommend moving this to C++ side and updating it. A similar implementation exist in node url

Will look it up. Thanks.

I tried to look it up in the code but I couldn't find it.
Do you mind linking a reference to the similar implementation so I can check it out?

src/node_process_methods.cc

lib/internal/process/per_thread.js

ShogunPanda · 2025-01-07T06:50:09Z

What about moving the platform dependent code to libuv? Maybe taking libuv/libuv#3120 to the finish line would be a good idea.

I'm sorry but I have very limited bandwidth lately. Trying to contribute to a codebase I never already did to it's not feasible for me.

Once this lands everyone is absolutely welcome to port this to libuv.

nodejs-github-bot · 2025-01-07T09:31:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64382/

nodejs-github-bot · 2025-01-07T14:10:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64384/

juanarbol · 2025-01-07T21:01:11Z

What about moving the platform dependent code to libuv? Maybe taking libuv/libuv#3120 to the finish line would be a good idea.

if that PR is orphaned, I can work on that one. Can I @jasnell?

ShogunPanda · 2025-01-08T05:00:32Z

@juanarbol Ok, I'll pause on this until you update me about libuv PR. Thanks for taking care of that!

juanarbol · 2025-01-09T03:54:05Z

@juanarbol Ok, I'll pause on this until you update me about libuv PR. Thanks for taking care of that!

There we go libuv/libuv#4666

ShogunPanda · 2025-01-09T05:09:41Z

Amazing! Keep up posted when this is released in libuv so I can update the dependencies and make this PR much leaner :)

Do you have an approximate ETA?

juanarbol · 2025-01-09T16:40:21Z

Do you have an approximate

I do not. They asked for macOS support, I'm gonna send patches on my spare time, I think I have some slots today and tomorrow after work. But idk when is the next release.

I just gave support to macOS and addressed all the comments.

juanarbol · 2025-01-14T19:56:58Z

@ShogunPanda Paolo, ~~the feature is landed and it is about to be released see libuv/libuv#4667~~

The feature is released!

ShogunPanda · 2025-01-18T07:50:33Z

@juanarbol Thanks for your effort on this.
Since #56616 has landed, I updated this to use the new API.
This is now ready to be reviewed!

nodejs-github-bot · 2025-02-20T14:40:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65339/

nodejs-github-bot · 2025-02-20T15:26:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65342/

nodejs-github-bot · 2025-02-20T16:21:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65345/

nodejs-github-bot · 2025-02-21T07:29:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65353/

nodejs-github-bot · 2025-02-21T08:42:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65355/

nodejs-github-bot · 2025-02-21T09:28:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65356/

mcollina

lgtm

nodejs-github-bot · 2025-02-21T14:14:04Z

Landed in e027791

ShogunPanda requested review from anonrig, joyeecheung and mcollina January 4, 2025 06:54

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jan 4, 2025

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2025

anonrig reviewed Jan 5, 2025

View reviewed changes

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2025

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2025

santigimeno mentioned this pull request Jan 9, 2025

misc: implement uv_getrusage_thread libuv/libuv#4666

Merged

ShogunPanda force-pushed the thread-cpu-usage branch from 1fdd439 to 5b09f78 Compare January 18, 2025 07:48

ShogunPanda marked this pull request as ready for review January 18, 2025 07:50

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2025

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2025

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2025

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2025

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2025

process: add threadCpuUsage

a52e50d

ShogunPanda force-pushed the thread-cpu-usage branch from af713e4 to a52e50d Compare February 21, 2025 09:16

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2025

mcollina approved these changes Feb 21, 2025

View reviewed changes

ShogunPanda added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2025

nodejs-github-bot merged commit e027791 into nodejs:main Feb 21, 2025
57 checks passed

github-actions bot mentioned this pull request Feb 25, 2025

2025-02-26, Version 23.9.0 (Current) #57207

Merged

yassernasc mentioned this pull request Feb 25, 2025

Add threadCpuUsage holepunchto/bare-os#10

Merged

This was referenced Apr 8, 2025

v22.x-staging cherry-pick status #57799

Closed

2025-04-23, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS #57840

Merged

AbhiPrasad mentioned this pull request Apr 14, 2025

Node 24 Support getsentry/sentry-javascript#16058

Closed

github-actions bot mentioned this pull request Aug 26, 2025

2025-08-28, Version 22.19.0 'Jod' (LTS) #59641

Merged

Uh oh!

Conversation

ShogunPanda commented Jan 4, 2025

Uh oh!

nodejs-github-bot commented Jan 4, 2025

Uh oh!

nodejs-github-bot commented Jan 4, 2025

Uh oh!

santigimeno commented Jan 4, 2025

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anonrig Jan 5, 2025

Choose a reason for hiding this comment

Uh oh!

ShogunPanda Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

ShogunPanda Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShogunPanda commented Jan 7, 2025

Uh oh!

nodejs-github-bot commented Jan 7, 2025

Uh oh!

nodejs-github-bot commented Jan 7, 2025

Uh oh!

juanarbol commented Jan 7, 2025

Uh oh!

ShogunPanda commented Jan 8, 2025

Uh oh!

juanarbol commented Jan 9, 2025

Uh oh!

ShogunPanda commented Jan 9, 2025

Uh oh!

juanarbol commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juanarbol commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShogunPanda commented Jan 18, 2025

Uh oh!

nodejs-github-bot commented Feb 20, 2025

Uh oh!

nodejs-github-bot commented Feb 20, 2025

Uh oh!

nodejs-github-bot commented Feb 20, 2025

Uh oh!

nodejs-github-bot commented Feb 21, 2025

Uh oh!

nodejs-github-bot commented Feb 21, 2025

Uh oh!

nodejs-github-bot commented Feb 21, 2025

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

juanarbol commented Jan 9, 2025 •

edited

Loading

juanarbol commented Jan 14, 2025 •

edited

Loading