Skip to content

Add --max-heap-size option#58708

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
tannal:option
Mar 2, 2026
Merged

Add --max-heap-size option#58708
nodejs-github-bot merged 1 commit intonodejs:mainfrom
tannal:option

Conversation

@tannal
Copy link
Copy Markdown
Contributor

@tannal tannal commented Jun 14, 2025

This PR fixs #58686

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jun 14, 2025

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Jun 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.91%. Comparing base (5fe7800) to head (a57cee3).
⚠️ Report is 1761 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58708      +/-   ##
==========================================
- Coverage   90.16%   89.91%   -0.26%     
==========================================
  Files         637      655      +18     
  Lines      188001   192830    +4829     
  Branches    36881    37791     +910     
==========================================
+ Hits       169509   173379    +3870     
- Misses      11238    12004     +766     
- Partials     7254     7447     +193
Files with missing lines Coverage Δ
src/node_options.cc 84.71% <100.00%> (+0.26%) ⬆️

... and 211 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lluisemper
Copy link
Copy Markdown
Contributor

lluisemper commented Aug 3, 2025

Hey @tannal, great job on putting together this PR 🚀

Just a quick heads-up: there's a specific process the project follows for making changes, including commit message formatting and code style guidelines. You can check it out here: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#the-process-of-making-changes

Totally happy to help if you need a hand navigating any of it, feel free to reach out!

@tannal tannal force-pushed the option branch 2 times, most recently from 0dd92b4 to 1e23624 Compare August 7, 2025 11:11
@haramj
Copy link
Copy Markdown
Member

haramj commented Sep 21, 2025

@tannal Can I open a new PR to fix this issue?

@tannal
Copy link
Copy Markdown
Contributor Author

tannal commented Sep 22, 2025

@tannal Can I open a new PR to fix this issue?

It's up to you. I don't think we need another pr.

@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 3, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 3, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70656/

@BethGriggs BethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Feb 18, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71375/

@addaleax addaleax added semver-minor PRs that contain new features and should be released in the next minor version. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 2, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2026
@nodejs-github-bot nodejs-github-bot merged commit ddecee7 into nodejs:main Mar 2, 2026
73 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 2, 2026

Landed in ddecee7

@efekrskl efekrskl mentioned this pull request Mar 10, 2026
Closed
aduh95 pushed a commit that referenced this pull request Mar 25, 2026
@tannal @aduh95
cli: add --max-heap-size option
62d2cd4 
PR-URL: #58708
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actions github-actions bot mentioned this pull request Mar 31, 2026
Merged
nodejs-github-bot added a commit that referenced this pull request Mar 31, 2026
@nodejs-github-bot
2026-04-01, Version 25.9.0 (Current)
c104d5a 
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add using scopes to AsyncLocalStorage (Stephen Belanger) #61674
benchmark:
  * (SEMVER-MINOR) add benchmarks for experimental stream/iter (James M Snell) #62066
cli:
  * (SEMVER-MINOR) add --max-heap-size option (tannal) #58708
crypto:
  * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183
repl:
  * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188
  * (SEMVER-MINOR) remove dependency on domain module (Matteo Collina) #61227
sea:
  * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158
stream:
  * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066
test:
  * (SEMVER-MINOR) add tests for experimental stream/iter implementation (James M Snell) #62066
test_runner:
  * add exports option for module mocks (sangwook) #61727

PR-URL: #62522
aduh95 added a commit that referenced this pull request Mar 31, 2026
@aduh95
2026-04-01, Version 25.9.0 (Current)
8282409 
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add using scopes to `AsyncLocalStorage` (Stephen Belanger) #61674
cli:
  * (SEMVER-MINOR) add `--max-heap-size` option (tannal) #58708
crypto:
  * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183
repl:
  * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188
  * (SEMVER-MINOR) remove dependency on `node:domain` (Matteo Collina) #61227
sea:
  * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158
stream:
  * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066
test_runner:
  * add exports option for module mocks (sangwook) #61727

PR-URL: #62522
aduh95 added a commit that referenced this pull request Mar 31, 2026
@aduh95
2026-04-01, Version 25.9.0 (Current)
9f5a2c9 
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add using scopes to `AsyncLocalStorage` (Stephen Belanger) #61674
cli:
  * (SEMVER-MINOR) add `--max-heap-size` option (tannal) #58708
crypto:
  * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183
repl:
  * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188
  * (SEMVER-MINOR) remove dependency on `node:domain` (Matteo Collina) #61227
sea:
  * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158
stream:
  * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066
test_runner:
  * add exports option for module mocks (sangwook) #61727

PR-URL: #62522
aduh95 added a commit that referenced this pull request Apr 1, 2026
@aduh95
2026-04-01, Version 25.9.0 (Current)
86282b5 
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add using scopes to `AsyncLocalStorage` (Stephen Belanger) #61674
cli:
  * (SEMVER-MINOR) add `--max-heap-size` option (tannal) #58708
crypto:
  * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183
repl:
  * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188
  * (SEMVER-MINOR) remove dependency on `node:domain` (Matteo Collina) #61227
sea:
  * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158
stream:
  * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066
test_runner:
  * add exports option for module mocks (sangwook) #61727

PR-URL: #62522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gurgunday gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tannal @nodejs-github-bot @lluisemper @haramj @gurgunday @addaleax @BethGriggs @avivkeller