chore: remove usage of unnecessary util.promisify#3988
Merged
wraithgar merged 1 commit intorelease-nextfrom Nov 4, 2021
Merged
chore: remove usage of unnecessary util.promisify#3988wraithgar merged 1 commit intorelease-nextfrom
wraithgar merged 1 commit intorelease-nextfrom
Conversation
wraithgar
approved these changes
Nov 4, 2021
Member
wraithgar
left a comment
wraithgar
left a comment
There was a problem hiding this comment.
~/D/n/cli (release-next|✔) $ nvm use 12lts
Now using node v12.13.0 (npm v6.12.0)
~/D/n/cli (release-next|✔) $ node
Welcome to Node.js v12.13.0.
Type ".help" for more information.
> require('fs').promises
{
access: [AsyncFunction: access],
...
This is safe to do now that we've dropped node 10 support. PR-URL: #3988 Credit: @lukekarrys Close: #3988 Reviewed-by: @wraithgar
wraithgar
force-pushed
the
lk/fs.promises
branch
from
c37988f to
32ccd3c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is safe to do now that we've dropped node 10 support.