Skip to content

Docs: MultiCommand.resultcallback vs MultiCommand.result_callback #1160

@NotTheEconomist

Description

@NotTheEconomist

The commands doc page shows usage of MultiCommand.resultcallback under the header "Multi Command Pipelines" as being a callable itself, that is passed all the associated callbacks with the chained group.

Where do the returned functions go? The chained multicommand can register a callback with MultiCommand.resultcallback() that goes over all these functions and then invoke them.

However, at the bottom of that same doc page, it seems to imply that MultiCommand.result_callback is the same.

Return values of groups can be processed through a MultiCommand.result_callback. This is invoked with the list of all return values in chain mode, or the single return value in case of non chained commands.

The API seems to show that result_callback is an attribute that stores the callback itself, while resultcallback is a function that sets what the callback should be. The naming here is confusing, and it's not clear which one is which. In addition: referring to both of them in the documentation (without clarifying which is which and why) throws an additional spanner into the works.

I recommend a rename for a permanent solution (result_callback -> _result_callback) and more explicit documentation in the short-term.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions