command and group decorators are untyped on strict

[Jonxslays]

Summary:
The click.command and click.group decorators are currently untyped and cause typing errors on strict pyright. (I haven't tested with mypy).

Replication:

• Install click
• Install pyright

# pyproject.toml

[tool.pyright]
typeCheckingMode = "strict"

# main.py

import click

@click.command()
def cli_main() -> None:
    ...

@click.group()
def cli_group() -> None:
    ...

These decorators are both unknown due to the use of typing.Callable with no generics. PR incoming.

Environment:

• Python version: 3.10.4
• Click version: 8.1.2

[davidism]

From the typing docs: https://docs.python.org/3/library/typing.html#typing.Callable

A plain Callable is equivalent to Callable[..., Any], and in turn to collections.abc.Callable.

This should be reported to pyright.

[Jonxslays]

Interesting, I will open a discussion there. Thanks!

[davidism]

Fix is fine, I merged it. But pyright shouldn't be reporting it in the first place. Please leave a link here to the issue.

[Jonxslays]

Opened microsoft/pyright#3386 regarding this.