bpo-35397: Remove deprecation and document urllib.parse.unwrap#11481
Merged
csabella merged 5 commits intopython:masterfrom May 27, 2019
Merged
bpo-35397: Remove deprecation and document urllib.parse.unwrap#11481csabella merged 5 commits intopython:masterfrom
csabella merged 5 commits intopython:masterfrom
Conversation
merwok
reviewed
Jan 9, 2019
merwok
reviewed
Jan 10, 2019
merwok
approved these changes
Jan 10, 2019
Contributor
|
@remilapeyre, please apply the change suggested by @merwok. Thanks! |
Co-Authored-By: Éric Araujo <merwok@netwok.org>
Author
|
Thanks @csabella, it's done ! |
Contributor
|
@remilapeyre, the builds are failing because of the new documentation you added to the So, based on the suggestion there, you need to edit |
Author
|
Thanks @csabella, this is now fixed. |
Contributor
|
@remilapeyre, thank you for the contribution! @merwok, thank you for the review! 🎉 |
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35397