bpo-42142: Try to fix timeouts in ttk tests#23474
Merged
serhiy-storchaka merged 6 commits intopython:masterfrom Nov 30, 2020
Merged
bpo-42142: Try to fix timeouts in ttk tests#23474serhiy-storchaka merged 6 commits intopython:masterfrom
serhiy-storchaka merged 6 commits intopython:masterfrom
Conversation
Check whether the widget is already visible before waiting a <VisibilityNotify> event.
serhiy-storchaka
added
tests
Contributor
|
Also addresses bpo-42370 |
Member
Author
Member
|
Putting repeated problematic test im a function is a great idea. Pipelines Windows tests failed consistently with "RuntimeError: Widget .!labeledscale is still not mapped". Presume same for GH Actions. Maybe revert to wait_visibility on Windows, where it apparently always worked? |
Member
Author
|
Actually, using
|
serhiy-storchaka
changed the title
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 30, 2020
Instead of using wait_visibility() which waits event <VisibilityNotify> in dead loop use update() which should proceed all queued events. (cherry picked from commit 6cc2c41) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-23565 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 30, 2020
Instead of using wait_visibility() which waits event <VisibilityNotify> in dead loop use update() which should proceed all queued events. (cherry picked from commit 6cc2c41) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-23566 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 30, 2020
Instead of using wait_visibility() which waits event <VisibilityNotify> in dead loop use update() which should proceed all queued events. (cherry picked from commit 6cc2c41) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 30, 2020
Instead of using wait_visibility() which waits event <VisibilityNotify> in dead loop use update() which should proceed all queued events. (cherry picked from commit 6cc2c41) Co-authored-by: Serhiy Storchaka <[email protected]>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Instead of using wait_visibility() which waits event <VisibilityNotify> in dead loop use update() which should proceed all queued events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check whether the widget is already visible before waiting a
<VisibilityNotify>event.https://bugs.python.org/issue42142