Skip to content

bpo-30935: update get_event_loop docs#2731

Merged
1st1 merged 2 commits intopython:masterfrom
daxlab:bpo_30935
May 29, 2018
Merged

bpo-30935: update get_event_loop docs#2731
1st1 merged 2 commits intopython:masterfrom
daxlab:bpo_30935

Conversation

@daxlab
Copy link
Copy Markdown
Contributor

@daxlab daxlab commented Jul 16, 2017 •
edited by bedevere-bot
Loading

@mention-bot
Copy link
Copy Markdown

mention-bot commented Jul 16, 2017

@daxlab, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld to be a potential reviewer.

cjerdonek
cjerdonek reviewed Jul 16, 2017
View reviewed changes
Doc/library/asyncio-eventloops.rst Outdated
Copy link
Copy Markdown
Member

@cjerdonek cjerdonek Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to say this not in the documentation of the interface, but in the documentation of the default policy.

Also, in the bpo issue I suggested adding a "Changed in 3.6" directive, but I don't see that here.

Copy link
Copy Markdown
Contributor Author

@daxlab daxlab Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it already there ?

Copy link
Copy Markdown
Member

@cjerdonek cjerdonek Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In "What's New," yes, but not in the asyncio section of the docs.

Copy link
Copy Markdown
Member

@cjerdonek cjerdonek Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the documentation of AbstractEventLoop.run_forever() for an example. In this case, it says, "Changed in version 3.5.1."

@Mariatta Mariatta added needs backport to 3.6 docs Documentation in the Doc dir labels Sep 10, 2017
Mariatta
Mariatta requested changes Sep 10, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the "Changed in 3.6" directive as suggested by @cjerdonek

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 10, 2017

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@daxlab daxlab requested a review from 1st1 as a code owner October 1, 2017 07:44
@daxlab
bpo-30935: update get_event_loop docs
0adbac1 
add version changed directive
@daxlab
Copy link
Copy Markdown
Contributor Author

daxlab commented Oct 1, 2017

I didn't expect the Spanish Inquisition!

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Oct 1, 2017

Nobody expects the Spanish Inquisition!

@Mariatta: please review the changes made to this pull request.

cjerdonek
cjerdonek requested changes Oct 1, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@cjerdonek cjerdonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still doesn't update the get_event_loop() docs as I said in the original bpo issue and in my previous review comment.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Oct 1, 2017

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@1st1
Copy link
Copy Markdown
Member

1st1 commented Oct 19, 2017

Please update the docstring of get_event_loop()

@csabella
Copy link
Copy Markdown
Contributor

csabella commented Feb 22, 2018

@daxlab There were some additional changes requested since your last commit. Would you be able to take a look at those? Thanks!

@1st1 1st1 closed this May 29, 2018
@1st1 1st1 reopened this May 29, 2018
@1st1 1st1 merged commit e55de2d into python:master May 29, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 29, 2018

Thanks @daxlab for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 29, 2018

GH-7213 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2018
@daxlab @miss-islington
bpo-30935: update get_event_loop docs (pythonGH-2731)
657ee40 
(cherry picked from commit e55de2d)

Co-authored-by: Mandeep Singh <daxlab@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 29, 2018

GH-7214 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2018
@daxlab @miss-islington
bpo-30935: update get_event_loop docs (pythonGH-2731)
f1e5d8e 
(cherry picked from commit e55de2d)

Co-authored-by: Mandeep Singh <daxlab@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 29, 2018
@miss-islington @daxlab
bpo-30935: update get_event_loop docs (GH-2731)
ca64f3e 
(cherry picked from commit e55de2d)

Co-authored-by: Mandeep Singh <daxlab@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 29, 2018
@miss-islington @daxlab
bpo-30935: update get_event_loop docs (GH-2731)
51bf38f 
(cherry picked from commit e55de2d)

Co-authored-by: Mandeep Singh <daxlab@users.noreply.github.com>
@daxlab daxlab deleted the bpo_30935 branch May 31, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjerdonek cjerdonek cjerdonek requested changes

@Mariatta Mariatta Mariatta requested changes

@1st1 1st1 1st1 approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@daxlab @mention-bot @bedevere-bot @1st1 @csabella @miss-islington @cjerdonek @Mariatta @the-knights-who-say-ni