Skip to content

bpo-33623: Fix possible SIGSGV when asyncio.Future is created in __del__#7080

Merged
1st1 merged 1 commit intopython:masterfrom
1st1:fixsigabort
May 28, 2018
Merged

bpo-33623: Fix possible SIGSGV when asyncio.Future is created in __del__#7080
1st1 merged 1 commit intopython:masterfrom
1st1:fixsigabort

Conversation

@1st1
Copy link
Copy Markdown
Member

@1st1 1st1 commented May 23, 2018 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from serhiy-storchaka May 23, 2018 18:59
@1st1 1st1 requested a review from asvetlov as a code owner May 23, 2018 18:59
@1st1 1st1 mentioned this pull request May 23, 2018
Closed
asvetlov
asvetlov approved these changes May 23, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Nice finding!

@1st1 1st1 merged commit 35230d0 into python:master May 28, 2018
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 28, 2018

@1st1: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 28, 2018

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@1st1 1st1 deleted the fixsigabort branch May 28, 2018 15:11
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 28, 2018

GH-7151 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2018
@1st1 @miss-islington
bpo-33623: Fix possible SIGSGV when asyncio.Future is created in __de…
fc90f69 
…l__ (pythonGH-7080)

(cherry picked from commit 35230d0)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 28, 2018

GH-7152 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2018
@1st1 @miss-islington
bpo-33623: Fix possible SIGSGV when asyncio.Future is created in __de…
c9ede63 
…l__ (pythonGH-7080)

(cherry picked from commit 35230d0)

Co-authored-by: Yury Selivanov <yury@magic.io>
miss-islington added a commit that referenced this pull request May 28, 2018
@miss-islington @1st1
bpo-33623: Fix possible SIGSGV when asyncio.Future is created in __de…
51d0a2c 
…l__ (GH-7080)

(cherry picked from commit 35230d0)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@1st1 @bedevere-bot @miss-islington @asvetlov @the-knights-who-say-ni