Throw LogicException when proc_open() is not installed#49
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Aug 14, 2017
Merged
Throw LogicException when proc_open() is not installed#49WyriHaximus merged 1 commit intoreactphp:masterfrom
WyriHaximus merged 1 commit intoreactphp:masterfrom
Conversation
WyriHaximus
approved these changes
Aug 12, 2017
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
LGTM, thanks for making this PR 👍
|
You could test it with a PHPT test specifying |
jsor
approved these changes
Aug 14, 2017
clue
approved these changes
Aug 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately I don't see any tests for exceptions — this would require mocking global functions.