Minor code style fix for stream_set_blocking() parameter type#218
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Nov 20, 2019
mmoreram:patch-1
Merged
Minor code style fix for stream_set_blocking() parameter type#218WyriHaximus merged 1 commit intoreactphp:masterfrom mmoreram:patch-1
WyriHaximus merged 1 commit intoreactphp:masterfrom
mmoreram:patch-1
Conversation
To be strict, the second parameter of this function is a `bool` instead of an `int`.
Member
|
Just look it up and that 0 has been there for 8+ years, essentially since the very beginnen of this package 😄 |
Contributor
Author
|
This library is 8 years old? OMG. |
Member
|
Github showed it as 8 years ago so could be 7.5 as well ;) |
clue
approved these changes
Nov 20, 2019
clue
changed the title
jsor
approved these changes
Nov 20, 2019
WyriHaximus
approved these changes
Nov 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be strict, the second parameter of this function is a
boolinstead of anint.