Fix closing connection when cancelling during TLS handshake#241
Merged
jsor merged 1 commit intoreactphp:masterfrom Jul 30, 2020
Merged
Fix closing connection when cancelling during TLS handshake#241jsor merged 1 commit intoreactphp:masterfrom
jsor merged 1 commit intoreactphp:masterfrom
Conversation
WyriHaximus
approved these changes
Jul 30, 2020
jsor
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes closing the pending connection attempt when the connection is cancelled during the TLS handshake. This is a minor oversight from the previous cleanup in 15426bd#diff-fa535a0ca5a2f2df7b368c67e3bfd18dL66. This is now covered by some higher level integration tests to ensure correct system behavior.