-
Notifications
You must be signed in to change notification settings - Fork 74
Runtime checks for occupied niches #624
Copy link
Copy link
Closed
Labels
T-compilerAdd this label so rfcbot knows to poll the compiler teamAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedA major change proposal that was accepted
Metadata
Metadata
Assignees
Labels
T-compilerAdd this label so rfcbot knows to poll the compiler teamAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedA major change proposal that was accepted
Type
Fields
Give feedbackNo fields configured for issues without a type.
Proposal
When executing a typed copy where the type contains a niche, the compiler may insert a runtime check that the type's niche(s) are unoccupied. In practical terms, these runtime checks will be inserted strategically in order to minimize runtime overhead (checking that every reference is not null every time they appear on the left side of a MIR assignment statement would have ridiculous overhead).
I have been slowly working on an implementation of this at rust-lang/rust#104862, following my work on #570
Mentors or Reviewers
I do not have any in mind
Process
The main points of the Major Change Process are as follows:
@rustbot second.-C flag, then full team check-off is required.@rfcbot fcp mergeon either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.