Only flycheck update the workspace that changed#11038
Only flycheck update the workspace that changed#11038pitaj wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
Apologies for having let this PR rot for a few months. Having read the linked issue I don't think this is the proper way forward to fix it mainly because of
This seems like a terrible user experience, if I change a crate I want to see the impact on all its dependants. So I am inclined to close this PR, we should instead investigate on reducing the flychecks to the crate that changed and its reverse dependencies. |
|
Obviously this isn't a full working solution. I pointed out those problems because I was hoping to get feedback on how to go about fixing them. |
|
Ah I apologize then, I unfortunately don't know enough about that part of the codebase currently. I'll have to see if I can find the time to get myself accustomed with that, though that might take a bit. |
|
So I looked into this, and my initial plan was to dig and then tell you about my findings but as it turned out this became more convoluted than I anticipated so I opened a new PR regarding this which will supercede this PR. Sorry, I hope you don't take this the wrong way :) Though the problem with your second point still persists, haven't looked into that yet #12808 |
| }; | ||
| if abs_path.starts_with(root) { | ||
| flycheck.update(); | ||
| // FIXME: break here? the file should only belong to one workspace |
There was a problem hiding this comment.
#[path] and include! would beg to differ 🥲.
feat: Only flycheck workspace that belongs to saved file Supercedes #11038 There is still the problem that all the diagnostics are cleared, only clearing diagnostics of the relevant workspace isn't easily doable though I think, will have to dig into that
3 participants
(Maybe) Fixes #8631
A couple problems: