Merged
Conversation
Member
|
I don't know why you put my name into the commit. You fixed it and John Firebaugh created minimal example. |
Contributor
Author
you are right, I wanted to put John Firebaugh in commit, somehow copied the wrong name. Fixed the commit message. |
Member
|
@bors r+ thanks! |
Contributor
|
📌 Commit 391ee79 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Feb 25, 2019
Fix ICE #3747 I'm not sure if this was the correct approach. I don't know if I put tests/ui/crashses/ice-3747.rs in correct place because the test always passed when I ran it with `cargo test`, even without the fix applied. If I run that test with `env CLIPPY_TESTS=true cargo run --bin clippy-driver -- -L ./target/debug tests/ui/crashes/ice-3747.rs` then the test correctly fails without the fix applied fixes #3747
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Apr 12, 2019
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 24, 2019
[stable] 1.34.1 point release The release date is April 25th. Included in this point release: * #59891: Fix the link to sort_by_cached_key * #59989: Fix links to Atomic* in RELEASES.md * rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747 * rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow... * rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 24, 2019
[stable] 1.34.1 point release The release date is April 25th. Included in this point release: * #59891: Fix the link to sort_by_cached_key * #59989: Fix links to Atomic* in RELEASES.md * rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747 * rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow... * rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 24, 2019
[stable] 1.34.1 point release The release date is April 25th. Included in this point release: * #59891: Fix the link to sort_by_cached_key * #59989: Fix links to Atomic* in RELEASES.md * rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747 * rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow... * rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 9, 2019
Pkgsrc changes: basically none. Build verified on NetBSD 8.0/i386. Upstream changes: Version 1.34.1 (2019-04-25) =========================== * [Fix false positives for the `redundant_closure` Clippy lint][clippy/3821] * [Fix false positives for the `missing_const_for_fn` Clippy lint][clippy/3844] * [Fix Clippy panic when checking some macros][clippy/3805] [clippy/3821]: rust-lang/rust-clippy#3821 [clippy/3844]: rust-lang/rust-clippy#3844 [clippy/3805]: rust-lang/rust-clippy#3805
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 19, 2019
Pkgsrc changes: basically none. Build verified on NetBSD 8.0/i386. Upstream changes: Version 1.34.1 (2019-04-25) =========================== * [Fix false positives for the `redundant_closure` Clippy lint][clippy/3821] * [Fix false positives for the `missing_const_for_fn` Clippy lint][clippy/3844] * [Fix Clippy panic when checking some macros][clippy/3805] [clippy/3821]: rust-lang/rust-clippy#3821 [clippy/3844]: rust-lang/rust-clippy#3844 [clippy/3805]: rust-lang/rust-clippy#3805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this was the correct approach.
I don't know if I put tests/ui/crashses/ice-3747.rs in correct place because the test always passed when I ran it with
cargo test, even without the fix applied.If I run that test with
env CLIPPY_TESTS=true cargo run --bin clippy-driver -- -L ./target/debug tests/ui/crashes/ice-3747.rsthen the test correctly fails without the fix appliedfixes #3747