Skip to content

Disable unnecessary_cast for cfg-dependant types#6369

Merged
bors merged 1 commit intorust-lang:masterfrom
camsteffen:cast-cfg
Nov 23, 2020
Merged

Disable unnecessary_cast for cfg-dependant types#6369
bors merged 1 commit intorust-lang:masterfrom
camsteffen:cast-cfg

Conversation

@camsteffen
Copy link
Copy Markdown
Contributor

changelog: Disable unnecessary_cast for cfg-dependant types

Fix #6331

@rust-highfive
Copy link
Copy Markdown

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 23, 2020
@camsteffen camsteffen changed the title Turn of unnecessary_cast for cfg-dependant types Disable unnecessary_cast for cfg-dependant types Nov 23, 2020
@Manishearth
Copy link
Copy Markdown
Member

I'm surprised the attribute sticks around after expansion, but if the test works it works

@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Nov 23, 2020

📌 Commit a39a93f has been approved by Manishearth

@bors
Copy link
Copy Markdown
Contributor

bors commented Nov 23, 2020

⌛ Testing commit a39a93f with merge 58a2bc4...

@bors
Copy link
Copy Markdown
Contributor

bors commented Nov 23, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 58a2bc4 to master...

@bors bors merged commit 58a2bc4 into rust-lang:master Nov 23, 2020
@camsteffen camsteffen deleted the cast-cfg branch July 8, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unnecessary_cast for u8 as c_char on some platforms

4 participants